Skip to content

discourse-doctor: prevent others from reading sensitive log content #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion discourse-doctor
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,8 @@ clean_up_log_file() {
echo "Replacing: $VAR"
sed -i -e 's/'"$VAR"'\([=: ]\)\S*/'"$VAR"'\1REDACTED /g' $LOG_FILE
done
# allow others to read the log for convenience, now that sensitive content has been redacted
chmod 0644 $LOG_FILE
}

print_done() {
Expand Down Expand Up @@ -352,7 +354,7 @@ print_done() {

initialize_log_file() {
rm -f $LOG_FILE
touch $LOG_FILE
install -m 0600 /dev/null $LOG_FILE
log DISCOURSE DOCTOR $(date)
log -e "OS: $(uname -a)\n\n"
}
Expand Down