add a typical example of initial load #648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
anuunchin
force-pushed
the
enh/pg_reaplication_pipeline
branch
4 times, most recently
from
98552a1 to
ff65c86
Compare
anuunchin
force-pushed
the
enh/pg_reaplication_pipeline
branch
from
ff65c86 to
cce8d1b
Compare
VioletM
requested changes
Sep 30, 2025
sources/pg_replication_pipeline.py
Outdated
| Returns: | ||
| None | ||
| """ | ||
| # create destination pipeline |
There was a problem hiding this comment.
Let's not call it the destination pipeline! Pipeline is a connection between source and destination, can we just call it replication_pipeline?
There was a problem hiding this comment.
how about we call them simulation and replication pipelines - i finally understand from the user perspective how source and destination pipelines sounds odd 🫡
anuunchin
force-pushed
the
enh/pg_reaplication_pipeline
branch
from
0d7562e to
9f6cbd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example to
the pg_replication_pipeline.pythat does NOT simulate a source postgres, so that users have a better idea on how to use pg_replication in production scenarios.pg_replication_pipeline.py, using the wordto simulateso that it's clear why we have source and destination pipelines separately.init_replicationdocstring also adjusted with the table ownership requirement for non superuser roles.Resolves #640