Skip to content

Expand documentation on the KubernetesImagesRepository setting. #22589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ctalledo
Copy link
Contributor

@ctalledo ctalledo commented May 5, 2025

Description

Provide our users more help on this setting. Place the info in the Kubernetes feature section, and link to it from the admin-settings description for KubernetesImagesRepository.

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security labels May 5, 2025
Copy link

netlify bot commented May 5, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e761bf7
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/681d1e24255e0900087a919d
😎 Deploy Preview https://deploy-preview-22589--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctalledo ctalledo force-pushed the doc-kubernetesImagesRepository branch 7 times, most recently from d73f282 to 6310219 Compare May 6, 2025 16:09
Copy link

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some nits

@ctalledo ctalledo force-pushed the doc-kubernetesImagesRepository branch from 6310219 to 9f76ba7 Compare May 7, 2025 00:33
@ctalledo
Copy link
Contributor Author

ctalledo commented May 7, 2025

LGTM! Just some nits

Thanks @landism, I've applied all your suggestions.

@ctalledo ctalledo force-pushed the doc-kubernetesImagesRepository branch from 9f76ba7 to 84192c3 Compare May 8, 2025 21:08
Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some editorial, style guide feedback

Provide our users more help on this setting. Place the info in the
Kubernetes feature section, and link to it from the admin-settings
description for KubernetesImagesRepository.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@ctalledo ctalledo force-pushed the doc-kubernetesImagesRepository branch from ab031ee to e761bf7 Compare May 8, 2025 21:12
@ctalledo
Copy link
Contributor Author

ctalledo commented May 8, 2025

Left some editorial, style guide feedback

Thanks @sarahsanders-docker, I've applied all your feedback. Please take a look again when you get a chance. Thanks again!

@sarahsanders-docker sarahsanders-docker merged commit 371f608 into docker:main May 8, 2025
14 checks passed
@ctalledo ctalledo deleted the doc-kubernetesImagesRepository branch May 8, 2025 21:19
sarahsanders-docker pushed a commit to sarahsanders-docker/docs that referenced this pull request May 9, 2025
…er#22589)

<!--Delete sections as needed -->

## Description

Provide our users more help on this setting. Place the info in the
Kubernetes feature section, and link to it from the admin-settings
description for KubernetesImagesRepository.

<!-- Tell us what you did and why -->

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [X] Editorial review
- [ ] Product review

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants