-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Expand documentation on the KubernetesImagesRepository setting. #22589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand documentation on the KubernetesImagesRepository setting. #22589
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d73f282
to
6310219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some nits
content/manuals/security/for-admins/hardened-desktop/settings-management/configure-json-file.md
Outdated
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/configure-json-file.md
Outdated
Show resolved
Hide resolved
6310219
to
9f76ba7
Compare
Thanks @landism, I've applied all your suggestions. |
9f76ba7
to
84192c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some editorial, style guide feedback
Provide our users more help on this setting. Place the info in the Kubernetes feature section, and link to it from the admin-settings description for KubernetesImagesRepository. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
ab031ee
to
e761bf7
Compare
Thanks @sarahsanders-docker, I've applied all your feedback. Please take a look again when you get a chance. Thanks again! |
…er#22589) <!--Delete sections as needed --> ## Description Provide our users more help on this setting. Place the info in the Kubernetes feature section, and link to it from the admin-settings description for KubernetesImagesRepository. <!-- Tell us what you did and why --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [X] Editorial review - [ ] Product review Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Description
Provide our users more help on this setting. Place the info in the Kubernetes feature section, and link to it from the admin-settings description for KubernetesImagesRepository.
Reviews