Skip to content

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jul 22, 2025

What does this PR do?

Add support for building image from a git remote context

TBD: this introduces a dependency on github.com/docker/docker/builder/remotecontext, need to check this is aligned with moby/moby#50280 trying to isolate a "moby API client" module from implementation details

Also left remote HTTP build context support for a follow-up PR

@ndeloof ndeloof force-pushed the build_remote branch 2 times, most recently from ba9dc77 to 95d50f2 Compare July 23, 2025 15:42
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add a test fetching a GH repo, i.e. https://github.com/testcontainers/helloworld? WDYT?

If fetching a repo could lead to flakiness at test time, how could we emulate the clone process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants