Skip to content

do not cut off bottom portion of text #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2025
Merged

do not cut off bottom portion of text #2568

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ddb2e6
fix: do not cut off bottom portion of text
dajrivera Jul 16, 2025
745ba13
Update src/themes/shared/_vars.css
sy-records Jul 17, 2025
d22ed31
update markdown h2 bottom-margin calculation
dajrivera Jul 17, 2025
a66ab1d
calculate h1, h2 top and bottom margins based on font line height
dajrivera Jul 18, 2025
5a14726
allow y overflow in h1, h2 headings
dajrivera Jul 23, 2025
fdce5fe
fix: safari has a slight ui difference using lh and em units instead …
dajrivera Jul 23, 2025
4c8efb7
Merge branch 'develop' into fix-bottom-text-cut-off
sy-records Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/themes/shared/_vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
--form-element-color : ;
--heading-color : var(--strong-color);
--heading-font-weight : 600;
--heading-line-height : calc(2ex + 5px); /* Unit required */
--heading-line-height : normal; /* Unit required */
--kbd-bg : var(--color-mono-1);
--kbd-border : 1px solid var(--color-mono-3);
--kbd-border-radius : 4px;
Expand Down
Loading