Release ckeditor 5 and geolocation changes #1367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial attempt to decrypt query string booking data and pre-populate the webform ...to be continued
- Added prepareForm function to set current wizard page when amending a booking. - Added function to get decrypted booking data from the request. - Amendments to alterForm to get booking data from request and prepopulate the form so it can be amended (work in progress). - Added function to check whether visitors have adult DOBs (needed to correctly identify adult visitors booking data from request). - Major refactor of function validateVisitBookingReference. Removed code for processing the visit reference number into a separate function so that it can be called separately outside of normal form validation - e.g. in the alterForm function.
Many changes... - Alter titles of wizard pages when amending - Added code to fully pre-populate webform with booking data - Alter preview page depending on whether amending, changing or cancelling a booking - Function for resetting form slots - happens when visitor order number changes or when amending a booking and user wants to change the timeslot - Many bugfixes
Stores unique identifiers from booking amendment links with a timestamp. Used to ensure booking amendment links can be used only once.
- Added logic to check whether a booking link has already been used by checking if the book link unique identifier already exists in the db. - Booking data is now retrieved from request in prepareForm function and stored in form_state. - dded logic to limit number of additional child visitors that can be selected based on how many adults there are.
- Many elements now have bottom margin only instead of top and bottom margin. - Styling changes and additions for .visit-details DLs
code stds.
code stds.
code stds
Pv amend scratch
Fixed bug relating to when user chooses to change a timeslot and picks new ones and then changes mind and wants to go back to the original booked timeslot.
Comment adjustment
Pv amend scratch
Add toggle styling for checkboxes with role="switch" and also some adjustments to styling for :checked radios and checkboxes.
Tweak to resetTimeSlots condition
- Separate function to handle form alterations when amending a booking - Custom confirmation messages depending on whether a booking is being kept, cancelled or changed - Various errors/warnings displayed when booking ref has an issue or timeslot cannot be changed because within notice period - Many fixes
- Tweaks to confirmation_visit_details template - Removed unneeded bkg_bkg_* hidden elements - Various messages introduced to handle invalid / expired visit order number, booking already amended, etc - Enable user to choose what they want to amend - Major changes to conditional logic for wizard pages - Custom confirmation messages for keeping, cancelling or amending booking - JS experiment to enable resetting of individual inputs - Separate email handlers for amending a booking
- Remove option to amend additional visitor details when visit type is virtual - Minor changes, comment adjustments
Fixes a bug where the original booking time slot is lost if the user chooses to change it and then changes mind and returns to the amend booking page.
- Add a default confirmation message into the form config so it sits along with other custom confirmation messages (instead of just falling back to the confirmation message declared in the webform settings). - Tweaks to confirmation message text
Place the button inside the input.
code stds
Pv amend scratch
Fix messages that show when time slot cannot be amended
- Move some amend booking form alterations out of alterFormToAmendBooking (which only runs once) and into the main alterForm logic so that it can run every time a wizard page is submitted (previous and next). - If notice period is exceeded, user must change the time slot. Make the option to change visit data and time readonly.
Catch all possible exceptions when attempting nominatim reverse lookup
Update GpSearchController.php
D8NID-1736 Prison visit booking: emails received by Prism have non-sequential SEQUENCE_ID values
D8 nid 1740
Updated to_mail, from_mail and adjusted email body content
Doesn't seem to work as designed at the present time so removing
Due to dependencies/phasing of its removal
Paragraph view mode needs preview as that is the one defaulted to in ckeditor when embedding the entity
…r-5-and-geolocation-changes
…itor-5-and-geolocation-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.