Set OutputType to Exe for xunit.v3, MSTest+MTP, and NUnit+MTP #15869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ViktorHofer I'm trying to experiment if this can reduce the noise when migrating repos.
I chose to do it in BeforeNETSdkTargets so that:
UseMSTestRunner,UseNUnitRunner, orTestRunnerNameare not set yet.OutputType. Note that Microsoft.NET.Test.Sdk (vstest) tries to set OutputType too late (NuGet targets), and is already too fragile and causes issues in certain cases that I can't recall for now.An alternative is to do this in
Tests.props, but that requires repos to setUseMSTestRunner,UseNUnitRunner, orTestRunnerNamebefore Arcade Sdk.props is imported. I tried to do it at the latest possible point.