-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix mathematically incorrect statements about empty sets in set documentation #11855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ation Co-authored-by: eiriktsarpalis <2813363+eiriktsarpalis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Can you update the other sets as well (ISet, HashSet, etc.)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all set types (ISet, HashSet, SortedSet) with the same fix in commit 65142cb.
<format type="text/markdown"><![CDATA[ | ||
## Remarks | ||
An empty set is a proper subset of any other collection. Therefore, this method returns `true` if the current set is empty, unless the `other` collection is also empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement ("An empty set is a proper subset of any other collection.") is also wrong. Update this and other occurrences (e.g. in ISet, HashSet, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the IsProperSubsetOf statements in all affected files (ImmutableSortedSet, ISet, HashSet, SortedSet). Changed "proper subset" to "subset" in commit 65142cb.
…er set types Co-authored-by: PranavSenthilnathan <12225508+PranavSenthilnathan@users.noreply.github.com>
Problem
The documentation for multiple set types contained mathematically incorrect statements about empty sets:
In
IsProperSupersetOf
methods:In
IsProperSubsetOf
methods:Both statements violate basic set theory principles.
Solution
Corrected all statements to align with mathematical set theory:
Mathematical Background
In set theory:
Change Details
Fixed incorrect statements in the following files:
ImmutableSortedSet`1.xml:
HashSet`1.xml:
SortedSet`1.xml:
ISet`1.xml:
All changes remove the word "proper" from the empty set statements to correctly reflect that an empty set is a subset (not a proper subset or proper superset) of all sets.
Impact
Corrects the mathematical explanations without affecting functionality. The method behavior remains unchanged - the documentation now accurately describes what the methods return.
Fixes #11853
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.