Skip to content

Fix broken xrefs #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2019
Merged

Fix broken xrefs #2576

merged 2 commits into from
Jun 11, 2019

Conversation

rpetrusha
Copy link

Fix broken xrefs

@rpetrusha rpetrusha added this to the June 2019 milestone Jun 10, 2019
@rpetrusha rpetrusha self-assigned this Jun 10, 2019
mairaw
mairaw approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left some comments for you to consider

xml/System/DateTime.xml Outdated
<format type="text/markdown"><![CDATA[


<a name="parse-remarks"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is not really broken, I'd prefer that we file a bug for the build report since the current link experience is better.

xml/System/StackOverflowException.xml Outdated
If your app hosts the common language runtime (CLR), it can specify that the CLR should unload the application domain where the stack overflow exception occurs and let the corresponding process continue. For more information, see [ICLRPolicyManager Interface](~/docs/framework/unmanaged-api/hosting/iclrpolicymanager-interface.md).
<a name="examples"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Suggested change
<a name="examples"></a>

@rpetrusha rpetrusha merged commit 64c8615 into dotnet:master Jun 11, 2019
@rpetrusha rpetrusha deleted the bad-xrefs branch June 11, 2019 22:49
@carlossanlop carlossanlop mentioned this pull request Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@rpetrusha @mairaw