Restored enumeration member remarks, Part 7 #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
added
the
migration-fixes
mairaw
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Changes look good @rpetrusha. Left some comments for your consideration.
| > [!NOTE] | ||
| > Although NoAccess and AllAccess are members of <xref:System.Security.Permissions.FileIOPermissionAccess.NoAccess>, they are not valid for use as the parameter for <xref:System.Security.Permissions.FileIOPermission.GetPathList%2A> because they describe no file access types or all file access types, respectively, and <xref:System.Security.Permissions.FileIOPermission.GetPathList%2A> expects a single file access type. | ||
| > [!NOTE] |
There was a problem hiding this comment.
not related to your changes, but this remarks made up mostly of notes looks weird to me
| </AssemblyInfo> | ||
| <ReturnValue> | ||
| <ReturnType>System.Security.Permissions.KeyContainerPermissionFlags</ReturnType> | ||
| </ReturnValue> |
There was a problem hiding this comment.
not related to your changes but the remarks for this type has a list of the powerful flags that should be fenced to prevent localization and that paragraph be added inside the caution note
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restored enumeration member remarks, Part 7
Contributes to #1306