Skip to content

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 14, 2019

Fixes #2539

I believe this PR takes care of the remaining samples that are not working with Try .NET and also removes (hopefully temporarily) the ones that make use of invariant culture.

@mairaw mairaw added this to the June 2019 milestone Jun 14, 2019
@mairaw mairaw requested a review from BillWagner June 14, 2019 01:16
@mairaw mairaw self-assigned this Jun 14, 2019
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @mairaw
You can :shipit: when ready.

@mairaw mairaw merged commit bf8d5af into dotnet:master Jun 14, 2019
@mairaw mairaw deleted the try-dotnet branch June 14, 2019 16:27
@mairaw mairaw added the doc-bug Problem with the content; needs to be fixed label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug Problem with the content; needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable interactive samples that fail
2 participants