SqlParameter - behaviour of Scale property for datetime2 parameters #2604
Conversation
Added note about setting scale on datetime2, datetimeoffset and time parameters. It is not possible to set the scale to 0 as this gets changed to 7 internally.
alansingfield
changed the title
|
Thanks @alansingfield for your PR. @afsanehr, @Gary-Zh , @David-Engel can one of you help review these changes to the System.Data.SqlClient.SqlParameter.Scale API? The staging link would be https://review.docs.microsoft.com/en-us/dotnet/api/System.Data.SqlClient.SqlParameter.Scale?branch=pr-en-us-2604&view=netframework-4.8#remarks. |
mairaw
added
the
✨ 1st-time dotnet-api-docs contributor!
|
@cheenamalhotra you're now listed as an owner of System.Data.SqlClient. Can you please review this PR for SqlParameter.Scale? |
There was a problem hiding this comment.
Thanks for the review @David-Engel. @alansingfield I have a couple of suggestions for you to consider. Thanks!
Oxford comma! Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Agreed Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
@mairaw Your review suggestions were implemented with the exception of the future tense to present tense suggestion -- is this OK to merge? |
|
Yes, thanks for checking @tdykstra. I tagged this on hold so I can push the SDP migration live first. |
Summary
Added note about setting scale on datetime2, datetimeoffset and time parameters. It is not possible to set the scale to 0 as this gets changed to 7 internally.
https://developercommunity.visualstudio.com/content/problem/161757/cannot-specify-scale-of-zero-for-time-datetime2-or.html
Describe your changes here.
Fixes #Issue_Number (if available)