Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2020

Summary

I changed snippet in transactedinstaller.cs
because I can't see all sample code in https://docs.microsoft.com/en-us/dotnet/api/system.configuration.install.transactedinstaller?view=netframework-4.8

Fixes #Issue_Number (if available)

@ghost ghost self-requested a review as a code owner March 17, 2020 16:29
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 17, 2020
@BillWagner
Copy link
Member

I'm waiting to review this, as I think it may have been fixed by the work @Thraka did in recovering a number of snipppets.

@Thraka Thraka added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Mar 18, 2020
@Thraka
Copy link
Contributor

Thraka commented Mar 18, 2020

@BillWagner The change @Asugakoisi is proposing actually just exposes more of the code, the entire sample (namespace declarations, the logging method, etc), which isn't many more lines. to what is published currently.

@Asugakoisi Is there somewhere you saw the snippet#2 being used? I can't find it anywhere. I think that //snippet2 can be removed from the sample.

@ghost
Copy link
Author

ghost commented Mar 20, 2020

I'm sorry for forgetting checking these comments.

I removed //snippet2

@Thraka Thraka merged commit 928241c into dotnet:master Mar 20, 2020
@Thraka
Copy link
Contributor

Thraka commented Mar 20, 2020

Thanks @Asugakoisi !!

@ghost ghost deleted the patch-1 branch March 21, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants