Merge master into live #4035
Merged
Merge master into live #4035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4028) * Add remarks regarding the initial content of span in string.Create * Apply suggestions Co-Authored-By: stephentoub <stoub@microsoft.com> * Apply suggestions Co-Authored-By: Jeremy Barton <jbarton@microsoft.com> Co-authored-by: stephentoub <stoub@microsoft.com> Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
The remarks section uses the following text for both the `UploadString()` and `UploadStringAsync()` methods: > Sends a String to the resource, without blocking the calling thread. I think this is a copy-and-paste error because only the `UploadStringAsync()` method is non-blocking. I have updated the description for `UploadString()` to follow the pattern used when describing other upload methods.
* RSACng.Encrypt used wrong "Pkcs1" link. * Checked the source code. Corrrection. * Resolve comment. * Keep exception description in Decrypt consistent with Encrypt.
The current implementation of `Flush` **does** flush the internal buffer.
Calling the Write method will not block current thread.
* Document behavior of StartProfile with null argument Contributes to dotnet/runtime#33426 * Update xml/System.Runtime/ProfileOptimization.xml Co-Authored-By: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
cxwtool
requested review from
bartonjs,
carlossanlop,
ericstj,
GrabYourPitchforks,
JeremyKuhne,
joperezr,
jozkee,
krwq and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't squash-merge this PR.