Fix overbuilding fsharp & define solution to build in script for VMR #18491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSharp was building two solutions in the VMR on Windows which resulted in the inner-build building the same thing but in parallel. The builds each take 7-8 minutes. Fix that by introducing a productBuild switch (which is already exposed in the Arcade scripts) and condition which solution to build on it or the existing source-build switch. Remove the /p:Projects property from DotNetBuild.props.
✅ No release notes required |
ViktorHofer
added a commit
to dotnet/dotnet
that referenced
this pull request
Apr 23, 2025
ViktorHofer
changed the title
1 task
mmitche
approved these changes
Apr 23, 2025
|
@dotnet/fsharp-team-msft this PR fixes build failures inside the VMR. We were essentially building fsharp twice on Windows - unintentionally. Can you please review, approve and merge? TIA |
ViktorHofer
commented
Apr 23, 2025
T-Gro
reviewed
Apr 24, 2025
T-Gro
reviewed
Apr 24, 2025
T-Gro
approved these changes
Apr 24, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
ViktorHofer
deleted the
FixOverBuildingFSharpInVMRAndSpecifyProjectToBuildInScript
branch
11 tasks
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#5005
Fixes dotnet/source-build#5071
Contributes to dotnet/dotnet#176
FSharp was building two solutions in the VMR on Windows which resulted in the inner-build building the same thing but in parallel. The builds each take 7-8 minutes. Fix that by introducing a productBuild switch (which is already exposed in the Arcade scripts) and condition which solution to build on it.
Remove the /p:Projects property from DotNetBuild.props.
Also delete the source-build logic from Build.ps1 as source-build isn't supported on Windows today.
VMR validation build: dotnet/dotnet#188