Skip to content

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Jun 12, 2025

This PR restructures the GH actions into two jobs.
First one runs and executes arbitrary code, and is by nature unsafe. It ends with creating a diff patch, and does not have any write permissions to anything.
The second job is not user extensible, and applies the diff to the source branch of the PR.

The following comments in a PR can be used as commands to execute scripts which automate repository maintenance and make it part of the visible diff.

  • /run fantomas runs dotnet fantomas .
  • /run ilverify updates IL verification baseline
  • /run xlf refreshes localisation files for translatable strings
  • /run test-baseline ... runs tests with the TEST_UPDATE_BSL: 1 environment variable and an argument supplied filter (passed to dotnet test --filter ..). Its goal is to refresh baselines.

@edgarfgp , @auduchinok : Are there other types of content changes that would also made use of a command, and would not be covered by the above?

TODO - add channel for variables about outcome between jobs
Copy link
Contributor

✅ No release notes required

@T-Gro T-Gro marked this pull request as ready for review June 16, 2025 08:29
@T-Gro T-Gro requested a review from a team as a code owner June 16, 2025 08:29
@T-Gro T-Gro requested review from abonie, edgarfgp and auduchinok June 16, 2025 08:41
@edgarfgp
Copy link
Contributor

@T-Gro would be possible to include Re-running the CI ?

@T-Gro
Copy link
Member Author

T-Gro commented Jun 16, 2025

Will have to figure out how to do it without a dummy commit (my current naive idea) and without risks with exposing the access token. Will check how this is done elsewhere.

@vzarytovskii
Copy link
Member

vzarytovskii commented Jun 16, 2025

Will have to figure out how to do it without a dummy commit (my current naive idea) and without risks with exposing the access token. Will check how this is done elsewhere.

/azp run will rerun the CI, or was it removed?

@T-Gro
Copy link
Member Author

T-Gro commented Jun 16, 2025

/azp run will rerun the CI, or was it removed?

AFAIK it never worked for OSS contributors, who also do not have the "rerun" buttons when seeing the Checks tab on a PR.
@edgarfgp : What happens when you try /azp run please?

@edgarfgp
Copy link
Contributor

/azp run

Copy link

Commenter does not have sufficient privileges for PR 18688 in repo dotnet/fsharp

@edgarfgp
Copy link
Contributor

@T-Gro i get Commenter does not have sufficient privileges for PR 18688 in repo dotnet/fsharp

@T-Gro T-Gro requested review from mmitche and vzarytovskii June 18, 2025 07:33
@vzarytovskii
Copy link
Member

/azp run will rerun the CI, or was it removed?

AFAIK it never worked for OSS contributors, who also do not have the "rerun" buttons when seeing the Checks tab on a PR.

@edgarfgp : What happens when you try /azp run please?

Correct, but what if it's person's own PR? I thought arcade folks fixed it - that you can rerun own PR.

@edgarfgp
Copy link
Contributor

/azp run will rerun the CI, or was it removed?

AFAIK it never worked for OSS contributors, who also do not have the "rerun" buttons when seeing the Checks tab on a PR.
@edgarfgp : What happens when you try /azp run please?

Correct, but what if it's person's own PR? I thought arcade folks fixed it - that you can rerun own PR.

Tried in my own PR and did not work. See #18670 (comment)

@T-Gro T-Gro enabled auto-merge (squash) July 3, 2025 13:05
@T-Gro T-Gro merged commit 0b26986 into main Jul 3, 2025
39 checks passed
@T-Gro T-Gro deleted the T-Gro-patch-commands-yml branch July 4, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants