-
Notifications
You must be signed in to change notification settings - Fork 824
Error on invalid declarations in type definitions. #18813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❗ Release notes required
|
tests/service/data/SyntaxTree/Type/Module Inside Type Defn 03.fs
Outdated
Show resolved
Hide resolved
I strongly believe it should be an error, just like in #15334. If we're targeting a new language version, I propose we make it an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved also with changing it from warn
to error
for users of languageversion=10.
tests/service/data/SyntaxTree/Type/Abstract Class With Invalid Constructs 01.fs
Outdated
Show resolved
Hide resolved
082655a
to
17e2f1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, as always Edgar :)
tests/FSharp.Compiler.ComponentTests/ErrorMessages/ErrorOnInvalidDeclsInTypeDefinitions.fs
Outdated
Show resolved
Hide resolved
@T-Gro Any chance I get some help updating the last failing .bsl tests. Im on a macOS and for some reason the use usual |
Description
Fixes #10066
Checklist