-
Notifications
You must be signed in to change notification settings - Fork 824
[WIP] RFC-1331 Expression-scoped opens #18814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❗ Release notes required
|
tests/service/data/SyntaxTree/OpenDeclaration/E_openInTypeDecl.fs
Outdated
Show resolved
Hide resolved
This PR does not implement "open in types" feature. It needs some refactoring to implement the feature, which needs someone who knows a lot about the typechecking mechanics. I did make a prototype, but I am not satisfied on its restriction, working way and performance. It requires putting open declarations on the beginning of a type definition, and has bug in |
@ijklam : Thanks for the summary of the current state. I will convert the PR to a draft to prevent accidental merge for now. |
Description
Implements fsharp/fslang-suggestions#96
RFC fsharp/fslang-design#810
This PR only implements open in expressions. Open in type is not implemented.
Checklist