make devcontainer work with unpublished sdks #18847
Open
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables devcontainer also when global.json requests an unofficial new SDK (like we now often have).
The change is not really nice, but the only way that I found after much trying.
The issue is that the Microsoft SDK devcontainer images install dotnet in
/usr, whileeng/common/dotnet.sh(which is needed to get the unofficial SDK) installs into the workspace folder, and, unfortunately, this cannot be changed.While the local version is fine for terminal use, it is not found by Ionide, that's why the copying in postCreateCommand is necessary.
Not so nice is that on creation you get a lot of error messages from Ionide. After reload, however, everything works fine.
@vzarytovskii @baronfel : Any other ideas?
Related: #18715
EDIT:
Maybe the root issue is that Ionide doesn't respect the
remoteEnv:PATH. If I understand the devcontainer documentation correctly, it should. (?)