-
Notifications
You must be signed in to change notification settings - Fork 407
Update System.CommandLine #4022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f528cc9
to
7b9ed57
Compare
7b9ed57
to
e4e3f5f
Compare
@@ -84,8 +84,7 @@ | |||
<PackageVersion Include="SkiaSharp" Version="3.119.0" /> | |||
<PackageVersion Include="StreamJsonRpc" Version="2.21.69" /> | |||
<PackageVersion Include="System.Collections.Immutable" Version="9.0.6" /> | |||
<PackageVersion Include="System.CommandLine.NamingConventionBinder" Version="2.0.0-beta4.22272.1" /> | |||
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> | |||
<PackageVersion Include="System.CommandLine" Version="2.0.0-rc.1.25413.101" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - I remember us removing all System.CommandLine dependencies (when you made the parser changes) but don't recall when we added it back...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.CommandLine had been used for parsing magic commands. That code was removed and a new, more fit-for-purpose parser was written. System.CommandLine was never removed for actual command line parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad - I thought it had been removed as part of the push to get all the interactive pieces to GA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the driver, but also the magic command parser needed improvements that couldn't be implemented with System.CommandLine, while System.CommandLine was also having features removed to prepare it for GA.
e4e3f5f
to
f3ee69b
Compare
No description provided.