Skip to content

Update System.CommandLine #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonsequitur
Copy link
Contributor

No description provided.

@jonsequitur jonsequitur force-pushed the update-System.CommandLine branch from f528cc9 to 7b9ed57 Compare August 18, 2025 17:27
@jonsequitur jonsequitur force-pushed the update-System.CommandLine branch from 7b9ed57 to e4e3f5f Compare August 18, 2025 18:00
@@ -84,8 +84,7 @@
<PackageVersion Include="SkiaSharp" Version="3.119.0" />
<PackageVersion Include="StreamJsonRpc" Version="2.21.69" />
<PackageVersion Include="System.Collections.Immutable" Version="9.0.6" />
<PackageVersion Include="System.CommandLine.NamingConventionBinder" Version="2.0.0-beta4.22272.1" />
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
<PackageVersion Include="System.CommandLine" Version="2.0.0-rc.1.25413.101" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I remember us removing all System.CommandLine dependencies (when you made the parser changes) but don't recall when we added it back...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.CommandLine had been used for parsing magic commands. That code was removed and a new, more fit-for-purpose parser was written. System.CommandLine was never removed for actual command line parsing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad - I thought it had been removed as part of the push to get all the interactive pieces to GA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the driver, but also the magic command parser needed improvements that couldn't be implemented with System.CommandLine, while System.CommandLine was also having features removed to prepare it for GA.

@jonsequitur jonsequitur force-pushed the update-System.CommandLine branch from e4e3f5f to f3ee69b Compare August 21, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants