[iOS] Fix: FilePicker.PickAsync hangs on swipe-to-dismiss in older iOS versions #30289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Follow up to (#29498)
This PR ensures FilePicker.PickAsync completes correctly when the user dismisses the file picker by swiping down on iOS older versions , where WasCancelled is not reliably triggered. ( I can reproduce this on iOS15.5).
Somehow in older iOS versions dismissing the
UIDocumentPickerViewControllervia swipe-down gesture does not invoke theWasCancelledevent. As a result, theTaskCompletionSourceis never completed, causing PickAsync to hang.Fix
UIPresentationController.Delegatewas already used in the legacy delegate-based file picker path.This PR extends that logic to also apply to the modern event-based picker API (DidPickDocumentAtUrls, WasCancelled), ensuring consistent cancellation handling across all code paths.
Issues Fixed
Fixes #30282