prevent tabs from being removed during Disappearing #30290
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR stops removing tab views during Android modal navigation by unhooking the disappearing event handler and deleting the associated method, making Android behavior align with iOS.
- Remove
OnTabbedPageDisappearingsubscription inSetElement - Delete
OnTabbedPageDisappearingmethod - Prevent tabs from being removed on page disappearance
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Platform/Android/TabbedPageManager.cs:124
- Add automated tests in TestCases.Shared.Tests and TestCases.HostApp to verify that tabs are not removed when a TabbedPage disappears on Android. Ensure each UI element has a unique AutomationId so the tests reliably locate the correct tabs.
Element.Appearing -= OnTabbedPageAppearing;
|
Hey there @@pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
During modal navigation, on android, the tabs are removed from layout, the reason is lost in time and this PR is to see if something break and if doesn't remove this behavior and make it better aligned with iOS.
Issues Fixed
Fixes CommunityToolkit/Maui#2708