Skip to content

Fix missing quotes in NetAnalyzers...RulesVersion expression #7675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trympet
Copy link

@trympet trympet commented May 30, 2025

What

  • Fixes a syntax error causing a conditional to always evaluate as false.
  • Fixes a malformed regex matching too many characters

Why
Fixes dotnet/roslyn#63036

Testing
I manually patched C:\Program Files\dotnet\sdk\9.0.300\Sdks\Microsoft.NET.Sdk\analyzers\build\Microsoft.CodeAnalysis.NetAnalyzers.targets on my dev box to incorporate the fix.

After patching it, setting any of the analysis mode properties below will include the corresponding editorconfig.

<AnalysisModeDesign>All</AnalysisModeDesign>
<AnalysisModeDocumentation>All</AnalysisModeDocumentation>
<AnalysisModeGlobalization>All</AnalysisModeGlobalization>
<AnalysisModeInteroperability>All</AnalysisModeInteroperability>
<AnalysisModeMaintainability>All</AnalysisModeMaintainability>
<AnalysisModeNaming>All</AnalysisModeNaming>
<AnalysisModePerformance>All</AnalysisModePerformance>
<AnalysisModeSingleFile>All</AnalysisModeSingleFile>
<AnalysisModeReliability>All</AnalysisModeReliability>
<AnalysisModeSecurity>All</AnalysisModeSecurity>
<AnalysisModeStyle>All</AnalysisModeStyle>
<AnalysisModeUsage>All</AnalysisModeUsage>

@trympet trympet requested a review from a team as a code owner May 30, 2025 16:41
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.83%. Comparing base (f45672f) to head (c1ac09c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7675      +/-   ##
==========================================
- Coverage   96.84%   96.83%   -0.01%     
==========================================
  Files        1220     1220              
  Lines      308701   308701              
  Branches     9553     9553              
==========================================
- Hits       298961   298946      -15     
- Misses       7394     7408      +14     
- Partials     2346     2347       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trympet trympet force-pushed the u/trymflogard/fix-netanalyzers-analysis-level branch from 63f228d to c1ac09c Compare May 30, 2025 17:09
@genlu
Copy link
Member

genlu commented May 30, 2025

@JoeRobich do you know who owns these analyzers now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnalysisLevel property does not affect Code Style
2 participants