-
Notifications
You must be signed in to change notification settings - Fork 1.2k
URL-encode scoped CSS Link headers for non-ASCII project names #51039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.1xx
Are you sure you want to change the base?
URL-encode scoped CSS Link headers for non-ASCII project names #51039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot address the feedback and make sure you don't modify unrelated files.
src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.ScopedCss.targets
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change. Undo
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/JsModulesIntegrationTest.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/LegacyStaticWebAssetsV1IntegrationTest.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetEndpointsIntegrationTest.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsBaselineFactory.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsCompressionIntegrationTest.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsFingerprintingTest.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/StaticWebAssetsIntegrationTest.cs
Show resolved
Hide resolved
test/Microsoft.NET.Sdk.StaticWebAssets.Tests/ScopedCssIntegrationTests.cs
Show resolved
Hide resolved
Addressed feedback in commit 9e13d45:
|
src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.ScopedCss.targets
Outdated
Show resolved
Hide resolved
There seems to be this unrelated test failure that seems to be failing pretty consistently Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_fails_with_unsupported_host_rid(targetFramework: "net10.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with dogfood sdk script and blazor app.
All failures are marked as known build errors but build analysis does not want to get green. |
/ba-g build analysis should be green, all failures are known |
…ct names Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
…er project structure Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
69393b7
to
95dcef5
Compare
URL-encode scoped CSS Link headers for non-ASCII project names
Description
Blazor apps with non-ASCII project names (e.g. 中文) failed at runtime due to raw non-ASCII characters in generated Link headers for scoped CSS bundles.
Fixes #51038
Customer Impact
This is required to be compliant with GB18030 and deal with cases where project names use non-ascii characters.
Regression?
9.0
Risk
Updates the manifest generation logic to ensure we URL encode path segments on the Link header. No other header that we emit needs this treatment.
Verification
Packaging changes reviewed?