-
Notifications
You must be signed in to change notification settings - Fork 327
Added Pivot method to RelationalGroupedDataset #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @moredatapls! Is this ready for PR? I see the PR as "Draft". |
@imback82 It's still a draft because I wanted to run the tests locally but I'm getting a NullReferenceException when I try to run them, see the strack trace below. I probably didn't configure my environment correctly, is there any guide that describes the local setup? Built the jars and the worker and configured the DOTNET_WORKER_DIR to point to the publish directory.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but LGTM. Thanks @moredatapls !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, thanks @moredatapls !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for nit comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @moredatapls!
Added support for RelationalGroupedDataset.Pivot (excluding the overloads with values).
Fixes #591
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.