Skip to content

DarkMode (c) fix TitleBar issues #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 50 commits into
base: klaus/preview5/B
Choose a base branch
from

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented May 21, 2025

Fixes #12991.
Fixes #12992.

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner May 21, 2025 16:27
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label May 21, 2025
@KlausLoeffelmann KlausLoeffelmann changed the base branch from main to klaus/preview5/B May 21, 2025 16:27
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 28.26199% with 1391 lines in your changes missing coverage. Please review.

Project coverage is 76.47170%. Comparing base (8484b55) to head (42f2342).
Report is 8 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13500         +/-   ##
===================================================
- Coverage   76.59415%   76.47170%   -0.12246%     
===================================================
  Files           3230        3240         +10     
  Lines         639165      640246       +1081     
  Branches       47297       47408        +111     
===================================================
+ Hits          489563      489607         +44     
- Misses        146025      147057       +1032     
- Partials        3577        3582          +5     
Flag Coverage Δ
Debug 76.47170% <28.26199%> (-0.12246%) ⬇️
integration 18.72225% <16.55493%> (-0.06067%) ⬇️
production 50.81946% <28.26199%> (-0.17634%) ⬇️
test 97.40411% <ø> (ø)
unit 48.21387% <26.66323%> (-0.18743%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LeafShi1 and others added 3 commits May 22, 2025 09:03
Update Pre-Release Iteration and Resource Management Milestone to
preview6
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13483)
[main] Source code updates from dotnet/dotnet
[main] Source code updates from dotnet/dotnet
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkMode_c_FixTitleBarIssues branch from e0697dc to 189ed4f Compare May 23, 2025 05:02
dotnet-maestro bot added 2 commits May 24, 2025 02:49
[main] Source code updates from dotnet/dotnet
[main] Source code updates from dotnet/dotnet
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkMode_c_FixTitleBarIssues branch from 189ed4f to 88f3d10 Compare May 26, 2025 07:05
@KlausLoeffelmann KlausLoeffelmann changed the base branch from klaus/preview5/B to main May 26, 2025 07:30
dotnet-maestro bot and others added 2 commits May 27, 2025 02:45
[main] Source code updates from dotnet/dotnet
…he value to a new text box (dotnet#13526)

I think we forgot to update *pdwEffect after _owner.OnDragDrop(dragEvent);
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkMode_c_FixTitleBarIssues branch from 30e3fc1 to 42f2342 Compare May 27, 2025 18:15
@KlausLoeffelmann KlausLoeffelmann changed the base branch from main to klaus/preview5/B May 27, 2025 21:20
KlausLoeffelmann and others added 29 commits May 28, 2025 20:19
Co-authored-by: KlausLoeffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: KlausLoeffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: KlausLoeffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
…ession-bodied form

Co-authored-by: KlausLoeffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: KlausLoeffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
* CheckBoxes,
* RadioButtons
* Tabs.

Also:

* Move ApplyThemingImplicitly flag definition to CreateParams.
* Update approach to set ApplyThemingImplicitly control style.
* Delegate FlatStyle.Standard Button rendering to the System due to HighDpi issues in the VisualStyle-based renderers.
* By that, implement new architecture for extendeble DarkMode/Style renderers.
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkMode_c_FixTitleBarIssues branch from 42f2342 to f947b04 Compare May 29, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DarkMode Issues relating to Dark Mode feature
Projects
None yet
5 participants