Skip to content

Conversation

@Bregor
Copy link

@Bregor Bregor commented Dec 8, 2017

After parsing MAL's html, there is strange behaviour of the commas
in strings with multiple values:

$ moe -name "shirobako" -info
...
Producers:  Sotsu  , Movic  , Warner Bros.  , KlockWorx  , Showgate  , Infinite
Genres   :  Comedy  , Drama
...

After this patch commas looks like following:

$ moe -name "shirobako" -info
...
Genres   :  Comedy, Drama
Producers:  Sotsu, Movic, Warner Bros., KlockWorx, Showgate, Infinite
...

After parsing MAL's html, there is strange behaviour of the commas
in strings with multiple values:

    $ moe -name "shirobako" -info
    ...
    Producers:  Sotsu  , Movic  , Warner Bros.  , KlockWorx  , Showgate  , Infinite
    Genres   :  Comedy  , Drama
    ...

After this patch commas looks like following:

    $ moe -name "shirobako" -info
    ...
    Genres   :  Comedy, Drama
    Producers:  Sotsu, Movic, Warner Bros., KlockWorx, Showgate, Infinite
    ...
@dragonzurfer
Copy link
Owner

Thanks for the PR but it would be better if you made the changes under the comment extract info in fetchDetails https://github.com/dragonzurfer/moe/blob/master/moe.go#L240
to maintain readability since PrintParams is just for printing to terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants