-
Notifications
You must be signed in to change notification settings - Fork 29
Duck Player: reportMetric support #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 18 Jul 2025 13:48:07 GMT Android
File has changed Integration
File has changed Windows
File has changed Apple
File has changed |
c3e373b
to
19a125d
Compare
4470bdc
to
c5a93dc
Compare
830dbcb
to
21261a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 thing to change with regards to how the init methods are called, other than that, looking really good 👍🏻
e4ee827
to
184e5d4
Compare
365c6ad
to
20cc7c7
Compare
Regression tested on all platforms. The work supporting this on Android is due to go out next week. |
@shakyShane @jonathanKingston Can we get this merged to Duck Player to unblock Android, and in the meantime I can flesh out the TD to potentially incorporate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Error Handling Issues in Embed Creation
This commit introduces two bugs:
- The
ErrorBoundary
'sdidCatch
callback incorrectly accesseserror?.error
. Theerror
parameter is theError
object itself, causingundefined
to be passed tomessaging.metrics.reportExceptionWithError
and resulting in failed or incomplete exception reporting. - A
null
return fromcreateEmbedSettings
is now incorrectly treated as an error. This function's type annotation indicatesnull
is a valid return, leading toError('Embed not found')
being thrown and reported as a false positive.
special-pages/pages/duckplayer/app/index.js#L78-L88
content-scope-scripts/special-pages/pages/duckplayer/app/index.js
Lines 78 to 88 in 6c36057
embed = createEmbedSettings(window.location.href, settings); | |
if (!embed) { | |
throw new Error('Embed not found'); | |
} | |
} catch (e) { | |
messaging.metrics.reportException({ message: e.message, kind: EXCEPTION_KIND_INIT_ERROR }); | |
} | |
const didCatch = (error) => { | |
const message = error?.message; | |
messaging.metrics.reportExceptionWithError(error?.error); |
Was this report helpful? Give feedback by reacting with 👍 or 👎
Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1210602603977143?focus=true
Description
Implements the
reportMetric
shared method to increase observability of Duck PlayerTesting Steps
willThrow=true
to the Duck Player special pagereportMetric
message fires accordinglyChecklist
Please tick all that apply: