[iOS][Push Notification] Toggling feature off #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyutang-sandra
requested review from
a team and
daxtheduck
as code owners
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Mon, 13 Oct 2025 08:39:02 GMT legacy27 files identical
2 files changed
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -82802,10 +82802,9 @@
"widgetReporting": {
"state": "disabled"
},
"inactivityNotification": {
- "state": "enabled",
- "minSupportedVersion": "7.187.0",
+ "state": "disabled",
"description": "Local inactivity provisional notifications delivered to Notification Center.",
"targets": [
{
"localeLanguage": "en",
latest13 files identical
v5/ios-config.json--- v5/ios-config.json
+++ v5/ios-config.json
@@ -82802,10 +82802,9 @@
"widgetReporting": {
"state": "disabled"
},
"inactivityNotification": {
- "state": "enabled",
- "minSupportedVersion": "7.187.0",
+ "state": "disabled",
"description": "Local inactivity provisional notifications delivered to Notification Center.",
"targets": [
{
"localeLanguage": "en",
|
JSON approval analysis:Time updated: Mon, 13 Oct 2025 08:39:11 GMT legacy❌ Manual Review Required
latest❌ Manual Review Required
🎯 OVERALL APPROVAL STATUS❌ MANUAL REVIEW REQUIRED |
| "daysInactive": "7" | ||
| } | ||
| }, | ||
| "appShortcut": { |
There was a problem hiding this comment.
We ended up not using this remote override. Remove it together in this PR
hanyutang-sandra
removed
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211289533034357?focus=true
Description
Toggle provisional push notification feature off
Prepared now in case it needs to be toggled off in an emergency that I’m not around
Feature change process:
Note
Disables
iOSBrowserConfig.features.inactivityNotificationand removes theappShortcutfeature fromoverrides/ios-override.json.overrides/ios-override.json):iOSBrowserConfig:features.inactivityNotification(wasenabled).features.appShortcutentry.Written by Cursor Bugbot for commit 8082ecc. This will update automatically on new commits. Configure here.