Skip to content

Conversation

shakyShane
Copy link
Collaborator

Asana Task/Github Issue:

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@shakyShane
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions bot pushed a commit that referenced this pull request Sep 19, 2025
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Sep 19, 2025

Generated file outputs:

Time updated: Fri, 19 Sep 2025 13:28:24 GMT

legacy
21 files identical
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json

⚠️ File is identical

7 files changed
  • v3/android-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v4/android-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json (and 6 other files)
+++ v4/windows-config.json
@@ -109,8 +109,11 @@
                     "minSupportedVersion": "0.130.0"
                 },
                 "pageContext": {
                     "state": "internal"
+                },
+                "supportsStandaloneMigration": {
+                    "state": "internal"
                 }
             },
             "minSupportedVersion": "0.100.0",
             "settings": {
@@ -102256,9 +102259,10 @@
                 "domains": [
                     {
                         "domain": [
                             "duckduckgo.com",
-                            "duck.co"
+                            "duck.co",
+                            "ngrok.app"
                         ],
                         "patchSettings": [
                             {
                                 "op": "replace",
v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -109,8 +109,11 @@
                     "minSupportedVersion": "0.130.0"
                 },
                 "pageContext": {
                     "state": "disabled"
+                },
+                "supportsStandaloneMigration": {
+                    "state": "disabled"
                 }
             },
             "minSupportedVersion": "0.100.0",
             "settings": {
@@ -102777,9 +102780,10 @@
                 "domains": [
                     {
                         "domain": [
                             "duckduckgo.com",
-                            "duck.co"
+                            "duck.co",
+                            "ngrok.app"
                         ],
                         "patchSettings": [
                             {
                                 "op": "replace",
latest
4 files changed
  • v5/android-config.json
  • v5/ios-config.json
  • v5/macos-config.json
  • v5/windows-config.json
--- v5/windows-config.json (and 3 other files)
+++ v5/windows-config.json
@@ -109,8 +109,11 @@
                     "minSupportedVersion": "0.130.0"
                 },
                 "pageContext": {
                     "state": "internal"
+                },
+                "supportsStandaloneMigration": {
+                    "state": "internal"
                 }
             },
             "minSupportedVersion": "0.100.0",
             "settings": {
@@ -102256,9 +102259,10 @@
                 "domains": [
                     {
                         "domain": [
                             "duckduckgo.com",
-                            "duck.co"
+                            "duck.co",
+                            "ngrok.app"
                         ],
                         "patchSettings": [
                             {
                                 "op": "replace",
10 files identical
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json

⚠️ File is identical

Copy link

github-actions bot commented Sep 19, 2025

JSON approval analysis:

Time updated: Fri, 19 Sep 2025 13:38:37 GMT

legacy

❌ Manual Review Required

  • v3/android-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v3/ios-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v3/macos-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v3/windows-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v4/android-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v4/ios-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v4/macos-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v4/windows-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
latest

❌ Manual Review Required

  • v5/android-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v5/ios-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v5/macos-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)
  • v5/windows-config.json (4 total changes)
    Disallowed paths that require review:
    • /features/messageBridge/settings/domains/1/domain (add)
    • /features/messageBridge/settings/domains/1/patchSettings (add)
    • /features/messageBridge/settings/domains/0 (replace)
    • /features/aiChat/features/supportsStandaloneMigration (add)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

github-actions bot pushed a commit that referenced this pull request Sep 19, 2025
@shakyShane shakyShane added the DO NOT MERGE Don't merge this branch unless directed label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Don't merge this branch unless directed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant