Jkt/enable adsjs #3816

jonathanKingston · 2025-09-25T14:07:24Z

Asana Task/Github Issue:

Description

For @CrisBarreiro to debug issues.

Feature change process:

I have added a schema to validate this feature change.
I have tested this change locally in all supported browsers.
This code for the config change is ready to merge.
This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

Reported URL:
Problems experienced:
Platforms affected:
- iOS
- Android
- Windows
- MacOS
- Extensions
Tracker(s) being unblocked:
Feature being disabled/modified:
This change is a speculative mitigation to fix reported breakage.

This reverts commit d077ad5.

This reverts commit 64eb581.

github-actions · 2025-09-25T14:12:42Z

🔗 Preview Config for PR #3816

Last updated: 2025-09-25 14:12:41 UTC

github-actions · 2025-09-25T14:18:22Z

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

The best reviewer is most likely a feature or platform owner.
If they've got permission to approve, you're good to merge. See CODEOWNERS
As a fallback the Global owners are:

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

github-actions · 2025-09-25T14:18:23Z

Generated file outputs:

Time updated: Thu, 25 Sep 2025 14:30:09 GMT

legacy

27 files identical

trackers-unprotected-temporary.txt
v3/extension-brave-config.json
v3/extension-bravemv3-config.json
v3/extension-chrome-config.json
v3/extension-chromemv3-config.json
v3/extension-config.json
v3/extension-edg-config.json
v3/extension-edge-config.json
v3/extension-edgmv3-config.json
v3/extension-firefox-config.json
v3/extension-safarimv3-config.json
v3/ios-config.json
v3/macos-config.json
v3/windows-config.json
v4/extension-brave-config.json
v4/extension-bravemv3-config.json
v4/extension-chrome-config.json
v4/extension-chromemv3-config.json
v4/extension-config.json
v4/extension-edg-config.json
v4/extension-edge-config.json
v4/extension-edgmv3-config.json
v4/extension-firefox-config.json
v4/extension-safarimv3-config.json
v4/ios-config.json
v4/macos-config.json
v4/windows-config.json

⚠️ File is identical

2 files changed

v3/android-config.json
v4/android-config.json

--- v4/android-config.json (and 1 other files)
+++ v4/android-config.json
@@ -395,17 +395,29 @@
                 "apiChanges": {},
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -37269,8 +37281,34 @@
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android",
+                            "minSupportedVersion": 52490000
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "disabled"
+                            }
+                        ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs",
+                            "minSupportedVersion": 52490000
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -42841,17 +42879,29 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -42859,17 +42909,29 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             },
             "exceptions": [
@@ -42999,17 +43061,29 @@
                 },
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             },
             "exceptions": [
@@ -43093,17 +43167,29 @@
                 },
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             },
             "exceptions": [
@@ -43159,17 +43245,29 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -43264,17 +43362,29 @@
                 ],
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -48808,9 +48918,9 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
@@ -48820,8 +48930,20 @@
                         ]
                     },
                     {
                         "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
+                    },
+                    {
+                        "condition": {
                             "context": {
                                 "frame": true
                             }
                         },
@@ -49183,9 +49305,10 @@
         "clientContentFeatures": {
             "state": "enabled",
             "features": {
                 "useNewWebCompatApis": {
-                    "state": "disabled"
+                    "state": "enabled",
+                    "minSupportedVersion": 52490000
                 }
             },
             "exceptions": []
         },

latest

v5/android-config.json

--- v5/android-config.json
+++ v5/android-config.json
@@ -395,17 +395,29 @@
                 "apiChanges": {},
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -37269,8 +37281,34 @@
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android",
+                            "minSupportedVersion": 52490000
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "disabled"
+                            }
+                        ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs",
+                            "minSupportedVersion": 52490000
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -42841,17 +42879,29 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -42859,17 +42909,29 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             },
             "exceptions": [
@@ -42999,17 +43061,29 @@
                 },
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             },
             "exceptions": [
@@ -43093,17 +43167,29 @@
                 },
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             },
             "exceptions": [
@@ -43159,17 +43245,29 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -43264,17 +43362,29 @@
                 ],
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
                                 "path": "/additionalCheck",
                                 "value": "disabled"
                             }
                         ]
+                    },
+                    {
+                        "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
                     }
                 ]
             }
         },
@@ -48808,9 +48918,9 @@
             "settings": {
                 "conditionalChanges": [
                     {
                         "condition": {
-                            "injectName": "android-adsjs"
+                            "injectName": "android"
                         },
                         "patchSettings": [
                             {
                                 "op": "add",
@@ -48820,8 +48930,20 @@
                         ]
                     },
                     {
                         "condition": {
+                            "injectName": "android-adsjs"
+                        },
+                        "patchSettings": [
+                            {
+                                "op": "add",
+                                "path": "/additionalCheck",
+                                "value": "enabled"
+                            }
+                        ]
+                    },
+                    {
+                        "condition": {
                             "context": {
                                 "frame": true
                             }
                         },
@@ -49183,9 +49305,10 @@
         "clientContentFeatures": {
             "state": "enabled",
             "features": {
                 "useNewWebCompatApis": {
-                    "state": "disabled"
+                    "state": "enabled",
+                    "minSupportedVersion": 52490000
                 }
             },
             "exceptions": []
         },

13 files identical

v5/extension-brave-config.json
v5/extension-bravemv3-config.json
v5/extension-chrome-config.json
v5/extension-chromemv3-config.json
v5/extension-config.json
v5/extension-edg-config.json
v5/extension-edge-config.json
v5/extension-edgmv3-config.json
v5/extension-firefox-config.json
v5/extension-safarimv3-config.json
v5/ios-config.json
v5/macos-config.json
v5/windows-config.json

⚠️ File is identical

github-actions · 2025-09-25T14:18:24Z

JSON approval analysis:

Time updated: Thu, 25 Sep 2025 14:40:15 GMT

legacy

❌ Manual Review Required

v3/android-config.json (55 total changes)
Disallowed paths that require review:
- /features/webCompat/settings/conditionalChanges/8/condition (add)
- /features/webCompat/settings/conditionalChanges/8/patchSettings (add)
- /features/webCompat/settings/conditionalChanges/7/condition (add)
- /features/webCompat/settings/conditionalChanges/7/patchSettings (add)
- /features/webCompat/settings/conditionalChanges/0 (replace)
- /features/webCompat/settings/additionalCheck (replace)
- /features/gpc/settings/conditionalChanges/2/condition (add)
- /features/gpc/settings/conditionalChanges/2/patchSettings (add)
- /features/gpc/settings/conditionalChanges/1/condition (add)
- /features/gpc/settings/conditionalChanges/1/patchSettings (add)
- /features/gpc/settings/conditionalChanges/0 (replace)
- /features/gpc/settings/additionalCheck (replace)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/0 (replace)
- /features/fingerprintingTemporaryStorage/settings/additionalCheck (replace)
- /features/fingerprintingScreenSize/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/0 (replace)
- /features/fingerprintingScreenSize/settings/additionalCheck (replace)
- /features/fingerprintingHardware/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingHardware/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingHardware/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingHardware/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingHardware/settings/conditionalChanges/0 (replace)
- /features/fingerprintingHardware/settings/additionalCheck (replace)
- /features/fingerprintingCanvas/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/0 (replace)
- /features/fingerprintingCanvas/settings/additionalCheck (replace)
- /features/fingerprintingBattery/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingBattery/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingBattery/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingBattery/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingBattery/settings/conditionalChanges/0 (replace)
- /features/fingerprintingBattery/settings/additionalCheck (replace)
- /features/clientContentFeatures/features/useNewWebCompatApis/state (replace)
- /features/clientContentFeatures/features/useNewWebCompatApis/minSupportedVersion (add)
- /features/breakageReporting/settings/conditionalChanges/2/condition (add)
- /features/breakageReporting/settings/conditionalChanges/2/patchSettings (add)
- /features/breakageReporting/settings/conditionalChanges/1/condition (add)
- /features/breakageReporting/settings/conditionalChanges/1/patchSettings (add)
- /features/breakageReporting/settings/additionalCheck (replace)
- /features/apiManipulation/settings/conditionalChanges/2/condition (add)
- /features/apiManipulation/settings/conditionalChanges/2/patchSettings (add)
- /features/apiManipulation/settings/conditionalChanges/1/condition (add)
- /features/apiManipulation/settings/conditionalChanges/1/patchSettings (add)
- /features/apiManipulation/settings/conditionalChanges/0 (replace)
- /features/apiManipulation/settings/additionalCheck (replace)
v4/android-config.json (55 total changes)
Disallowed paths that require review:
- /features/webCompat/settings/conditionalChanges/8/condition (add)
- /features/webCompat/settings/conditionalChanges/8/patchSettings (add)
- /features/webCompat/settings/conditionalChanges/7/condition (add)
- /features/webCompat/settings/conditionalChanges/7/patchSettings (add)
- /features/webCompat/settings/conditionalChanges/0 (replace)
- /features/webCompat/settings/additionalCheck (replace)
- /features/gpc/settings/conditionalChanges/2/condition (add)
- /features/gpc/settings/conditionalChanges/2/patchSettings (add)
- /features/gpc/settings/conditionalChanges/1/condition (add)
- /features/gpc/settings/conditionalChanges/1/patchSettings (add)
- /features/gpc/settings/conditionalChanges/0 (replace)
- /features/gpc/settings/additionalCheck (replace)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/0 (replace)
- /features/fingerprintingTemporaryStorage/settings/additionalCheck (replace)
- /features/fingerprintingScreenSize/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/0 (replace)
- /features/fingerprintingScreenSize/settings/additionalCheck (replace)
- /features/fingerprintingHardware/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingHardware/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingHardware/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingHardware/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingHardware/settings/conditionalChanges/0 (replace)
- /features/fingerprintingHardware/settings/additionalCheck (replace)
- /features/fingerprintingCanvas/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/0 (replace)
- /features/fingerprintingCanvas/settings/additionalCheck (replace)
- /features/fingerprintingBattery/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingBattery/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingBattery/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingBattery/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingBattery/settings/conditionalChanges/0 (replace)
- /features/fingerprintingBattery/settings/additionalCheck (replace)
- /features/clientContentFeatures/features/useNewWebCompatApis/state (replace)
- /features/clientContentFeatures/features/useNewWebCompatApis/minSupportedVersion (add)
- /features/breakageReporting/settings/conditionalChanges/2/condition (add)
- /features/breakageReporting/settings/conditionalChanges/2/patchSettings (add)
- /features/breakageReporting/settings/conditionalChanges/1/condition (add)
- /features/breakageReporting/settings/conditionalChanges/1/patchSettings (add)
- /features/breakageReporting/settings/additionalCheck (replace)
- /features/apiManipulation/settings/conditionalChanges/2/condition (add)
- /features/apiManipulation/settings/conditionalChanges/2/patchSettings (add)
- /features/apiManipulation/settings/conditionalChanges/1/condition (add)
- /features/apiManipulation/settings/conditionalChanges/1/patchSettings (add)
- /features/apiManipulation/settings/conditionalChanges/0 (replace)
- /features/apiManipulation/settings/additionalCheck (replace)

latest

❌ Manual Review Required

v5/android-config.json (55 total changes)
Disallowed paths that require review:
- /features/webCompat/settings/conditionalChanges/8/condition (add)
- /features/webCompat/settings/conditionalChanges/8/patchSettings (add)
- /features/webCompat/settings/conditionalChanges/7/condition (add)
- /features/webCompat/settings/conditionalChanges/7/patchSettings (add)
- /features/webCompat/settings/conditionalChanges/0 (replace)
- /features/webCompat/settings/additionalCheck (replace)
- /features/gpc/settings/conditionalChanges/2/condition (add)
- /features/gpc/settings/conditionalChanges/2/patchSettings (add)
- /features/gpc/settings/conditionalChanges/1/condition (add)
- /features/gpc/settings/conditionalChanges/1/patchSettings (add)
- /features/gpc/settings/conditionalChanges/0 (replace)
- /features/gpc/settings/additionalCheck (replace)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingTemporaryStorage/settings/conditionalChanges/0 (replace)
- /features/fingerprintingTemporaryStorage/settings/additionalCheck (replace)
- /features/fingerprintingScreenSize/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingScreenSize/settings/conditionalChanges/0 (replace)
- /features/fingerprintingScreenSize/settings/additionalCheck (replace)
- /features/fingerprintingHardware/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingHardware/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingHardware/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingHardware/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingHardware/settings/conditionalChanges/0 (replace)
- /features/fingerprintingHardware/settings/additionalCheck (replace)
- /features/fingerprintingCanvas/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingCanvas/settings/conditionalChanges/0 (replace)
- /features/fingerprintingCanvas/settings/additionalCheck (replace)
- /features/fingerprintingBattery/settings/conditionalChanges/2/condition (add)
- /features/fingerprintingBattery/settings/conditionalChanges/2/patchSettings (add)
- /features/fingerprintingBattery/settings/conditionalChanges/1/condition (add)
- /features/fingerprintingBattery/settings/conditionalChanges/1/patchSettings (add)
- /features/fingerprintingBattery/settings/conditionalChanges/0 (replace)
- /features/fingerprintingBattery/settings/additionalCheck (replace)
- /features/clientContentFeatures/features/useNewWebCompatApis/state (replace)
- /features/clientContentFeatures/features/useNewWebCompatApis/minSupportedVersion (add)
- /features/breakageReporting/settings/conditionalChanges/2/condition (add)
- /features/breakageReporting/settings/conditionalChanges/2/patchSettings (add)
- /features/breakageReporting/settings/conditionalChanges/1/condition (add)
- /features/breakageReporting/settings/conditionalChanges/1/patchSettings (add)
- /features/breakageReporting/settings/additionalCheck (replace)
- /features/apiManipulation/settings/conditionalChanges/2/condition (add)
- /features/apiManipulation/settings/conditionalChanges/2/patchSettings (add)
- /features/apiManipulation/settings/conditionalChanges/1/condition (add)
- /features/apiManipulation/settings/conditionalChanges/1/patchSettings (add)
- /features/apiManipulation/settings/conditionalChanges/0 (replace)
- /features/apiManipulation/settings/additionalCheck (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

CrisBarreiro and others added 6 commits September 25, 2025 11:58

Disable useNewWebCompatApis

d077ad5

Disable adsjs changes

64eb581

Revert "Disable useNewWebCompatApis"

b06d6b2

This reverts commit d077ad5.

Revert "Disable adsjs changes"

c53bfd3

This reverts commit 64eb581.

Enable it all

08fed4b

Merge remote-tracking branch 'origin/main' into jkt/enable-adsjs

0a7690e

github-actions bot pushed a commit that referenced this pull request Sep 25, 2025

Publish config for PR #3816

5f94018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jkt/enable adsjs #3816

Jkt/enable adsjs #3816

Uh oh!

jonathanKingston commented Sep 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2025 •

edited

Loading

❌ Manual Review Required

❌ Manual Review Required

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jkt/enable adsjs #3816

Are you sure you want to change the base?

Jkt/enable adsjs #3816

Uh oh!

Conversation

jonathanKingston commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Feature change process:

Site breakage mitigation process:

Brief explanation

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated file outputs:

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JSON approval analysis:

❌ Manual Review Required

❌ Manual Review Required

🎯 OVERALL APPROVAL STATUS

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jonathanKingston commented Sep 25, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited

Loading