Skip to content

Fixed image renaming feature, which could lead to duplicated file names if using gallery #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed image renaming feature, which could lead to duplicated file names if using gallery #550

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc6be77
Merge pull request #5 from dweeves/master
crysix Aug 11, 2017
72654c7
Fixed image renaming feature, which could lead to duplicated file nam…
crysix Aug 11, 2017
dcedb0e
Merge pull request #6 from dweeves/master
crysix Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions magmi/plugins/extra/itemprocessors/imageprocessor/imageitattributeemprocessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ public function handleGalleryTypeAttribute($pid, &$item, $storeid, $attrcode, $a
}
// use ";" as image separator
$images = explode(";", $ivalue);
$imageindex = 0;

// starting at 1, because otherwise if image renaming is used the main product image is already used for 0.
$imageindex = 1;

// for each image
foreach ($images as $imagefile) {
// trim image file in case of spaced split
Expand All @@ -106,7 +109,7 @@ public function handleGalleryTypeAttribute($pid, &$item, $storeid, $attrcode, $a
$imagefile = $infolist[0];
}
unset($infolist);
$extra=array("store"=>$storeid,"attr_code"=>$attrcode,"imageindex"=>$imageindex == 0 ? "" : $imageindex);
$extra=array("store"=>$storeid,"attr_code"=>$attrcode,"imageindex"=>$imageindex);
// copy it from source dir to product media dir
$imagefile = $this->copyImageFile($imagefile, $item, $extra);
unset($extra);
Expand Down Expand Up @@ -184,7 +187,7 @@ public function handleImageTypeAttribute($pid, &$item, $storeid, $attrcode, $att
$imagefile = trim($ivalue);

// else copy image file
$imagefile = $this->copyImageFile($imagefile, $item, array("store"=>$storeid, "attr_code"=>$attrcode));
$imagefile = $this->copyImageFile($imagefile, $item, array("store"=>$storeid, "attr_code"=>$attrcode,"imageindex"=>0));
$ovalue = $imagefile;
// add to gallery as excluded
if ($imagefile !== false) {
Expand Down