try to empty install dir if removing it fails #4932
+111
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2025 14:58
added 2 commits
June 26, 2025 13:12
|
@smoors As discussed during today's conf call, it probably makes sense to introduce another function ( |
smoors
changed the title
smoors
changed the title
boegel
requested changes
Aug 27, 2025
| from easybuild.tools.filetools import get_cwd, get_source_tarball_from_git, is_alt_pypi_url, is_binary, is_parent_path | ||
| from easybuild.tools.filetools import is_sha256_checksum, mkdir, move_file, move_logs, read_file, remove_dir | ||
| from easybuild.tools.filetools import remove_file, remove_lock, symlink, verify_checksum, weld_paths, write_file | ||
| from easybuild.tools.filetools import download_file, clean_dir, encode_class_name, extract_file |
There was a problem hiding this comment.
Suggested change
| from easybuild.tools.filetools import download_file, clean_dir, encode_class_name, extract_file | |
| from easybuild.tools.filetools import clean_dir, download_file, encode_class_name, extract_file |
|
|
||
| def make_dir(self, dir_name, clean, dontcreateinstalldir=False): | ||
| def make_dir(self, dir_name, clean, dontcreateinstalldir=False, isinstalldir=False): |
There was a problem hiding this comment.
isinstalldir can be renamed to something that more directly specifies what it done when this is enabled/disabled:
Suggested change
| def make_dir(self, dir_name, clean, dontcreateinstalldir=False, isinstalldir=False): | |
| def make_dir(self, dir_name, clean, dontcreateinstalldir=False, clean_instead_of_remove=False): |
Comment on lines
+450
to
+451
| except EasyBuildError: | ||
| _log.debug("Failed to remove directory %s, emptying it instead", path) |
There was a problem hiding this comment.
Suggested change
| except EasyBuildError: | |
| _log.debug("Failed to remove directory %s, emptying it instead", path) | |
| except EasyBuildError as err: | |
| _log.debug(f"Removing directory {path} failed, will try to empty it instead: {err}") |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for installing in bwrap namespace, see also #4110
if install dir is bind mounted, it cannot be removed