Handle post_install_patches and post_install_msgs for extensions
#4980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those EasyConfig parameters were silently ignored. Run the appropriate steps in the default implementation of `post_install_extension` similar to postinstall_cmds and add a test. Using the new name for `post_install_patches` in the test reveals the need to handle that explicitely as a raw dict is used.
2 tasks
boegel
changed the title
post_install_patches and post_install_msgs for extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those EasyConfig parameters were silently ignored. Run the appropriate steps in the default implementation of
post_install_extensionsimilar to postinstall_cmds and add a test. Using the new name forpost_install_patchesin the test reveals the need to handle that explicitely as a raw dict is used.