Skip to content

Conversation

LastStarDust
Copy link
Contributor

@LastStarDust LastStarDust commented Mar 27, 2025

I updated, fixed and revamped the CMake files to be compatible with ROS2 Jazzy and any recent version of protobuf.
I double checked that everything works in the following 4 combinations:

  • ROS2 humble
  • ROS2 jazzy
  • Protobuf v23
  • Protobuf v27

If you want, I could also push the shell scripts and VSCode configuration I used for troubleshooting the build.

@LastStarDust LastStarDust marked this pull request as draft March 27, 2025 07:31
@LastStarDust
Copy link
Contributor Author

LastStarDust commented Mar 27, 2025

The CI is failing because of some permission error. So I suspect an issue with the environment. I could take a look, but I see that I don't have the necessary legal authorization to open a PR, so I am wondering if it makes any sense that I continue working on this PR to begin with.

@tfoote
Copy link
Contributor

tfoote commented Apr 10, 2025

@mbeards found the solution to CI on #38 was the CMake Version to get CI running. I confirmed that the baseline CI passes in #39

You likely need this equivalent fix.
85d6769

@LastStarDust
Copy link
Contributor Author

I applied that fix but the original problem persists:

  [ 41%] Generating C++ type support for Protobuf
  gmake[2]: /__w/rosidl_typesupport_protobuf/rosidl_typesupport_protobuf/ros_ws/install/rosidl_typesupport_protobuf_cpp/lib/rosidl_typesupport_protobuf_cpp/rosidl_typesupport_protobuf_cpp: Permission denied
  gmake[2]: *** [CMakeFiles/unique_identifier_msgs__rosidl_typesupport_protobuf_cpp.dir/build.make:84: rosidl_typesupport_protobuf_cpp/unique_identifier_msgs/msg/detail/uuid__type_support.cpp] Error 127
  gmake[1]: *** [CMakeFiles/Makefile2:403: CMakeFiles/unique_identifier_msgs__rosidl_typesupport_protobuf_cpp.dir/all] Error 2
  gmake: *** [Makefile:146: all] Error 2

I will continue to investigate what kind of permission CMake is complaining abobut.

@mbeards
Copy link
Contributor

mbeards commented Apr 10, 2025

I applied that fix but the original problem persists:

  [ 41%] Generating C++ type support for Protobuf
  gmake[2]: /__w/rosidl_typesupport_protobuf/rosidl_typesupport_protobuf/ros_ws/install/rosidl_typesupport_protobuf_cpp/lib/rosidl_typesupport_protobuf_cpp/rosidl_typesupport_protobuf_cpp: Permission denied
  gmake[2]: *** [CMakeFiles/unique_identifier_msgs__rosidl_typesupport_protobuf_cpp.dir/build.make:84: rosidl_typesupport_protobuf_cpp/unique_identifier_msgs/msg/detail/uuid__type_support.cpp] Error 127
  gmake[1]: *** [CMakeFiles/Makefile2:403: CMakeFiles/unique_identifier_msgs__rosidl_typesupport_protobuf_cpp.dir/all] Error 2
  gmake: *** [Makefile:146: all] Error 2

I will continue to investigate what kind of permission CMake is complaining abobut.

I figured it out in fcb31c3

if(POLICY CMP0148)
  cmake_policy(SET CMP0148 OLD)
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants