Skip to content

fix MQTTDeserialize_unsubscribe didn't judge maxcount or may cause memory access violation #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix MQTTDeserialize_unsubscribe didn't judge maxcount or may cause memory access violation #259

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
452d6fa
fix MQTTDeserialize_unsubscribe didn't judge maxcount
Mar 2, 2024
7ac91eb
change comparison
Mar 5, 2024
d2b9d62
add test for invalid unsubscribe packet
Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MQTTPacket/src/MQTTUnsubscribeServer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ int32_t MQTTDeserialize_unsubscribe(unsigned char* dup, unsigned short* packetid
*count = 0;
while (curdata < enddata)
{
if (*count == maxcount)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= is safer.

Also, we'll need to scan all other APIs for possible similar issues.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to >=.But in MQTTV5Deserialize_subscribe,it use *count == maxcount to check.

goto exit;
if (!readMQTTLenString(&topicFilters[*count], &curdata, enddata))
goto exit;
(*count)++;
Expand Down