Skip to content

Conversation

grassesi
Copy link
Contributor

@grassesi grassesi commented Sep 22, 2025

Description

Issue Number

second part to #937, first part see #1086

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@grassesi grassesi force-pushed the sgrasse/develop/issue_937_refactor_sampling branch from 0137978 to 98eb175 Compare October 14, 2025 15:00
@grassesi grassesi changed the title refactor sampling refactor time logic in MultiStreamDataSampler Oct 14, 2025
@clessig clessig self-requested a review October 14, 2025 15:19
@grassesi grassesi force-pushed the sgrasse/develop/issue_937_refactor_sampling branch from 98eb175 to 76a2e2e Compare October 15, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant