feat: Add checkpoint update command #336
Conversation
HCookie
added
documentation
HCookie
force-pushed
the
feat/add_checkpoint_update_cmd
branch
from
01ae1f7 to
db7627b
Compare
There was a problem hiding this comment.
Maybe a bit more explicitness in the naming: redefine-graph for the command name, and utils/redefine_graph.py for the utils file?
For a review of the functional implementation maybe @dietervdb-meteo, @frazane and @havardhhaugen would like to have a look?
Co-authored-by: Gert Mertes <13658335+gmertes@users.noreply.github.com>
HCookie
force-pushed
the
feat/add_checkpoint_update_cmd
branch
from
6086dd4 to
71a8f25
Compare
| anemoi-inference redefine_graph path/to/checkpoint --coords 30.0 -10.0 20.0 0.0 0.1/0.1 --global_resolution n320 | ||
| All examples can optionally save the updated graph and checkpoint using the `--save-graph` and `--output` options. |
There was a problem hiding this comment.
Why did you chose to make the output optional? Shouldn't it be a mandatory positional argument?
There was a problem hiding this comment.
For arbitary convenience as it will add a suffix by default and still save it
There was a problem hiding this comment.
Sounds reasonable. I would clarify this in the docs.
| elif args.coords is not None: | ||
| local_lats, local_lons = get_coordinates_from_mars_request(args.coords) | ||
| else: | ||
| raise ValueError("No valid coordinates found.") |
There was a problem hiding this comment.
This won't be reached if argparse is working correctly but one more check doesn't hurt.
|
|
||
| def check_redefine_imports(): | ||
| """Check if required packages are installed.""" | ||
| required_packages = ["anemoi.datasets", "anemoi.graphs", "anemoi.models"] |
There was a problem hiding this comment.
Would it be useful to add these packages to the optional dependencies in the pyproject.toml, or is it up to the user to install these manually if they want to use this functionality?
5 participants
Description
For LAM or Nested Grid usage redefining the region or specification of the graph is useful for testing and exploration.
This PR formalises that process within a subcommand to allow easy usage.
It pulls the graph data from the checkpoint to ensure consistency, or allows for a full graph on disk to be used.
Usage
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-inference--336.org.readthedocs.build/en/336/