Skip to content

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Oct 17, 2025

Description

A couple improvements to the cutout input:

  • Remove pre_processors from top level cutout
  • Add _input to cutout states
  • Alter CutoutInput to take a list to provide an explicit ordering

Closes #356

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.


📚 Documentation preview 📚: https://anemoi-inference--355.org.readthedocs.build/en/355/

@HCookie HCookie requested a review from frazane October 17, 2025 17:02
@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Oct 17, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2025
@HCookie HCookie moved this from To be triaged to Under Review in Anemoi-dev Oct 17, 2025
@HCookie HCookie self-assigned this Oct 17, 2025
@frazane
Copy link
Contributor

frazane commented Oct 18, 2025

Tested and solves the issue. Thanks!

frazane
frazane previously approved these changes Oct 18, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2025
@HCookie HCookie changed the title fix: Remove pre_processors from top level cutout fix: CutoutInput improvements and upgrades Oct 18, 2025
@frazane
Copy link
Contributor

frazane commented Oct 18, 2025

Instead of an additional order key, why not consider #356?

Copy link
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Francesco: can we do something more clever with the order? I like the idea of requiring the inputs to be specified as a list, this could be optional so we don't break backwards compatibility (or we make it a breaking change to avoid ambiguity).

@HCookie
Copy link
Member Author

HCookie commented Oct 22, 2025

Sure, I'm happy to change it,
I think it will likely end up looking like

input:
  cutout:
		inputs:
	    - lam: ...
	    - global: ...

@github-actions github-actions bot added the tests label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS Approval not needed bug Something isn't working documentation Improvements or additions to documentation tests

Projects

Status: Under Review

Development

Successfully merging this pull request may close these issues.

Cutout input sources should be specified as a list

3 participants