-
Notifications
You must be signed in to change notification settings - Fork 20
fix: CutoutInput
improvements and upgrades
#355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tested and solves the issue. Thanks! |
CutoutInput
improvements and upgrades
Instead of an additional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Francesco: can we do something more clever with the order? I like the idea of requiring the inputs to be specified as a list, this could be optional so we don't break backwards compatibility (or we make it a breaking change to avoid ambiguity).
Sure, I'm happy to change it, input:
cutout:
inputs:
- lam: ...
- global: ... |
Description
A couple improvements to the cutout input:
pre_processors
from top level cutout_input
to cutout statesCutoutInput
to take a list to provide an explicit orderingCloses #356
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-inference--355.org.readthedocs.build/en/355/