Inline methods (and also memmapping I guess?) #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add inline statements
empty flag for path element enumeration
add but dont implement circular flag in path element callback
fix dangling file descriptor
Allow non-header lines as the first line in a GFA
don't write trailing tabs on optionless P-lines
better handle * path overlap field
pass through CPPFLAGS & LDFLAGS too
switch to Python3
Make detect_version_from_file return something
Protect application from corrupt GFA files missing required fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pertains to #51
Here's a PR with the inline methods I talked about. I guess we also have some commits from Erik about memmapping in our master branch. I'll let you look over those to decide whether you want both sets of edits.