fix: duplicate --max-pods arguments in KUBELET_EXTRA_ARGS #8533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guessi
changed the title
guessi
force-pushed
the
fix-duplicate-max-pods-7946
branch
from
f4d486c to
8e572a9
Compare
| set -ex | ||
| ` | ||
| script += fmt.Sprintf(`sed -i 's/KUBELET_EXTRA_ARGS=$2/KUBELET_EXTRA_ARGS="$2 --max-pods=%d"/' /etc/eks/bootstrap.sh`, maxPods) | ||
| script += fmt.Sprintf(`sed -i 's/KUBELET_EXTRA_ARGS=$2/KUBELET_EXTRA_ARGS="$(echo "$2" | sed "s/--max-pods=[0-9]*//" | sed "s/ */ /g" | sed "s/^ *//" | sed "s/ *$//") --max-pods=%d"/' /etc/eks/bootstrap.sh`, maxPods) |
There was a problem hiding this comment.
Are the duplicated --max-pods the same value or one value disagreeing?
Instead of removing the max pod with sed can we avoid setting it in two places? Still wrapping my head around this issue.
There was a problem hiding this comment.
I agree it should be prevented from the beginning, but we don't have control for what could be passed via $2 as it could always be customized by end users. ( unlike AL2023, it's all handled by NodeConfig )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7946 by preventing duplicate
--max-podsarguments inKUBELET_EXTRA_ARGSwhen using the deprecatedMaxPodsPerNodesetting with AL2 managed nodegroups.Problem
When
MaxPodsPerNodeis set, eksctl'smakeMaxPodsScriptfunction appends--max-podstoKUBELET_EXTRA_ARGSwithout checking if it already exists, resulting in:Solution
Modified
makeMaxPodsScriptto:--max-pods=<number>arguments using sed--max-podsvalueImpact
--max-podsissueTesting
The fix ensures only one
--max-podsargument appears inKUBELET_EXTRA_ARGS, with eksctl'sMaxPodsPerNodevalue taking precedence.