feat: add YAML anchors and aliases support to ClusterConfig #8535
+406
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guessi
force-pushed
the
feature/yaml-anchor-support
branch
from
457c0e8 to
98d11c5
Compare
guessi
commented
Oct 9, 2025
guessi
force-pushed
the
feature/yaml-anchor-support
branch
3 times, most recently
from
c6d24ff to
21eb238
Compare
- Add resolveYAMLAnchors() function to process YAML anchors and aliases - Remove only 'aliases' field to maintain strict validation for other fields - Include security protections against YAML bombs and excessive nesting - Add comprehensive test coverage for functionality and edge cases - Update FAQ documentation with YAML anchor examples Fixes eksctl-io#8270
guessi
force-pushed
the
feature/yaml-anchor-support
branch
from
21eb238 to
5152cb6
Compare
|
@NicholasBlaskey I've made some changes to the PR, with simplified solution, more test cases and FAQ section added, please review. |
guessi
commented
Oct 10, 2025
Comment on lines
+259
to
+260
| // Remove only the aliases field, maintaining strict validation for everything else | ||
| delete(temp, "aliases") |
There was a problem hiding this comment.
Updated the implementation to support special "aliases" section only.
guessi
commented
Oct 10, 2025
Comment on lines
+219
to
+223
| // Security: Limit input size to prevent memory exhaustion attacks | ||
| const maxInputSize = 1024 * 1024 // 1MB limit | ||
| if len(data) > maxInputSize { | ||
| return nil, fmt.Errorf("YAML input too large: %d bytes exceeds limit of %d bytes", len(data), maxInputSize) | ||
| } |
There was a problem hiding this comment.
YAML file over 1MB should be considered as abnormal, any concern?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8270