Skip to content

Conversation

Arsalan2078
Copy link

No description provided.

@UniquePixels
Copy link

What is the purpose of this? The comments serve an important documentation purpose, why remove them?

@elektronik2k5
Copy link
Contributor

And the comments are usually stripped when bundling anyways, so they don't make it into the final result that gets shipped down the wire to end users.

This PR in the current form mustn't be merged.

Copy link
Contributor

@elektronik2k5 elektronik2k5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the comments for documentation purposes. If the concern is bundle size then:

  1. These texts weigh next to nothing when compressed over the wire (which is the industry standard)
  2. Bundlers strip comments already in most configurations

@Arsalan2078
Copy link
Author

Arsalan2078 commented Dec 21, 2024

I apologize! I did not intend to merge it like that.

It's been a month ago, but I thought i forked the repository, so it would only have my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants