fix/test fallback serilog (#523) #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test fallback - update - Ensure fallback mechanism works with the latest ingest-dotnet (cherry picked from commit a4c06a5)
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
run docs-build |
snakefoot
reviewed
Jul 8, 2025
| @@ -136,8 +136,11 @@ public ElasticsearchSink(ElasticsearchSinkOptions<TEcsDocument> options) | |||
| var channelOptions = new DataStreamChannelOptions<TEcsDocument>(options.Transport) | |||
| { | |||
| DataStream = options.DataStream, | |||
| ExportMaxRetriesCallback = EmitExportFailures | |||
| ExportMaxRetriesCallback = EmitExportFailures, | |||
| ExportExceptionCallback = _ => | |||
There was a problem hiding this comment.
What value does assignment of empty-delegate for ExportExceptionCallback provide ?
There was a problem hiding this comment.
None, that's debug code I should have removed. Good catch !
|
@snakefoot, can you please check when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a4c06a5)