Skip to content

Fix client usage of the Inference API #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fix client usage of the Inference API #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
631408f
Fix client usage of the Inference API
pquentin Aug 30, 2024
85a3bb8
Ensure all variants run to completion in CI
pquentin Aug 30, 2024
ef566f5
Update one output and improve one debug call
pquentin Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
jobs:
notebook-tests:
strategy:
fail-fast: false
matrix:
es_stack:
- 8.14.2
Expand Down
8 changes: 4 additions & 4 deletions notebooks/search/07-inference.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@
"source": [
"API_KEY = getpass(\"OpenAI API key: \")\n",
"\n",
"client.inference.put_model(\n",
"client.inference.put(\n",
" task_type=\"text_embedding\",\n",
" inference_id=\"my_openai_embedding_model\",\n",
" body={\n",
Expand All @@ -211,7 +211,7 @@
"id": "1f2e48b7",
"metadata": {},
"source": [
"**NOTE:** If you use Elasticsearch 8.12, you must change `inference_id` in the snippet above to `model_id`! "
"**NOTE:** If you use Elasticsearch 8.12, you must change `inference_id` in the snippet above to `model_id`! And `inference.put` to `inference.put_model`."
]
},
{
Expand Down Expand Up @@ -409,7 +409,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3.12.3 64-bit",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand All @@ -423,7 +423,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.3"
"version": "3.12.5"
},
"vscode": {
"interpreter": {
Expand Down
Loading
Loading