Add p-value heuristics to significant terms aggregation

[pquentin]

Server code: https://github.com/elastic/elasticsearch/blob/e95971d802b1137efde30eb79c95e3baef7c2ccb/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/aggs/heuristic/PValueScore.java#L32-L62

Despite the 🔴 below, note that this fixes the validation of 8 YAML test requests.

[github-actions]

Following you can find the validation changes against the target branch for the API.

API	Status	Request	Response
search	🔴	2559/2637 → 2567/2637	2637/2637

You can validate this API yourself by using the make validate target.

[l-trotta]

nicely done with the docs and defaults!

[github-actions]

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5353-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2cddbefb265a4cffdcff8c2b6c29561429d8a499
# Push it to GitHub
git push --set-upstream origin backport-5353-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5353-to-8.19.

[github-actions]

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5353-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2cddbefb265a4cffdcff8c2b6c29561429d8a499
# Push it to GitHub
git push --set-upstream origin backport-5353-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5353-to-9.0.

[github-actions]

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5353-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2cddbefb265a4cffdcff8c2b6c29561429d8a499
# Push it to GitHub
git push --set-upstream origin backport-5353-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5353-to-9.1.

[pquentin]

💚 All backports created successfully

Status	Branch	Result
✅	9.1
✅	9.0
✅	8.19

Questions ?

Please refer to the Backport tool documentation