[ES|QL] LOOKUP JOIN: Query lookup index with ES|QL #230140
Conversation
…ndex-editor-query-bar
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
cc @darnautov |
| @@ -45,10 +52,20 @@ export const CustomPanel = () => { | |||
|
|
|||
| return ( | |||
| <EuiFlexGroup alignItems={'center'} gutterSize={'s'}> | |||
| <EuiFlexItem grow> | |||
| {dataView ? ( | |||
There was a problem hiding this comment.
No need to check for dataView, it will never try to render this if it's null: https://github.com/darnautov/kibana/blob/c977fdfdc0e4d0268b064eca6700344e1effc1b4/src/platform/packages/private/kbn-index-editor/src/components/query_bar.tsx#L41-L51
There was a problem hiding this comment.
I think you should check for indexCreated$ instead, I would hide the search bar, refresh button, and the discover button if the index is not created, as there is nothing to query yet.
| {dataView ? ( | ||
| <EuiSearchBar | ||
| defaultQuery={''} | ||
| onChange={({ queryText, query, error }) => { |
There was a problem hiding this comment.
| onChange={({ queryText, query, error }) => { | |
| onChange={({ queryText }) => { |
Or should we display this error? What kind of errors can this component return?
| ) | ||
| .pipe( | ||
| catchError((e) => { | ||
| // query might be invalid, so we return an empty response |
There was a problem hiding this comment.
Shall we display feedback to the user to differentiate valid querys with no results from wrongly formatted querys?
Summary
Part of #207330