Skip to content

Ignore MasterTimeout for serverless deployment #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

johnvanhienen
Copy link
Contributor

According to the docs, the master_timeout attribute should be ignored when creating a serverless deployment. However, this isn't currently happening in practice. When trying to create an index, the apply fails with this error:

│ Error: Unable to create index: fietslanduo
│
│   with module.elasticstack["test.fietsplan"].elasticstack_elasticsearch_index.this["fietslanduo"],
│   on modules/ec-elasticstack/indices.tf line 2, in resource "elasticstack_elasticsearch_index" "this":
│    2: resource "elasticstack_elasticsearch_index" "this" {
│
│ Failed with: {"error":{"root_cause":[{"type":"status_exception","reason":"Parameter validation
│ failed for [/fietslanduo]: The http parameter [master_timeout] (with value [30000ms]) is not
│ permitted when running in serverless mode"}],"type":"status_exception","reason":"Parameter
│ validation failed for [/fietslanduo]: The http parameter [master_timeout] (with value
│ [30000ms]) is not permitted when running in serverless mode"},"status":400}

I'm proposing to handle this parameter the same way it's handled as WaitForActiveShards, which is already being properly omitted in serverless deployments. I've tested this fix by building the provider locally, and it works as expected.

Copy link

cla-checker-service bot commented Jul 16, 2025

💚 CLA has been signed

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@tobio tobio merged commit 6dea22c into elastic:main Jul 18, 2025
23 checks passed
tobio added a commit that referenced this pull request Jul 18, 2025
* origin/main:
  Fix master timeout for serverless flavor (#1207)
  Add reroute processor data source for Elasticsearch ingest pipelines (#1204)
  chore(deps): update golang docker tag to v1.24.5 (#1202)
  chore(deps): update dependency go to v1.24.5 (#1200)
  Add support for timeslice metrics indicator (#1195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants