Ignore MasterTimeout for serverless deployment #1207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs, the
master_timeout
attribute should be ignored when creating a serverless deployment. However, this isn't currently happening in practice. When trying to create an index, the apply fails with this error:I'm proposing to handle this parameter the same way it's handled as
WaitForActiveShards
, which is already being properly omitted in serverless deployments. I've tested this fix by building the provider locally, and it works as expected.