-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: cannot download differentially because of space in range #9276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 15c1c74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mmaietta differentialUpdateTest keeps failing, and it seems the test server no longer supports this configuration. |
What do you mean by this? If the current test server doesn't accept the new differential range format, doesn't that signify this change is not backward compatible? |
|
I tried to understand how differentialUpdateTest.ts works, but I have no idea how it works and where exactly it fails and why it is not compatible |
|
I haven't found where this update server is yet. I haven't found it. |
|
@mmaietta I've found the reason for the UT failure; it's because we used the 'ran' server(https://github.com/m3ng9i/ran/tree/master/server), which doesn't support ranges without spaces. It seems the server didn't handle this case properly. According to RFC 7233, it should support both cases: with and without spaces. |
|
Do we need to update |
fix #9270