Skip to content

Conversation

@beyondkmp
Copy link
Contributor

fix #9270

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: 15c1c74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@beyondkmp beyondkmp changed the title fix: Cannot download differentially because of space in range fix: cannot download differentially because of space in range Sep 15, 2025
@beyondkmp beyondkmp requested a review from mmaietta September 15, 2025 03:35
@beyondkmp
Copy link
Contributor Author

@mmaietta differentialUpdateTest keeps failing, and it seems the test server no longer supports this configuration.

@mmaietta
Copy link
Collaborator

the test server no longer supports this configuration.

What do you mean by this? If the current test server doesn't accept the new differential range format, doesn't that signify this change is not backward compatible?

@cubimon
Copy link

cubimon commented Sep 24, 2025

I tried to understand how differentialUpdateTest.ts works, but I have no idea how it works and where exactly it fails and why it is not compatible

@beyondkmp
Copy link
Contributor Author

I haven't found where this update server is yet. I haven't found it.

@beyondkmp
Copy link
Contributor Author

@mmaietta I've found the reason for the UT failure; it's because we used the 'ran' server(https://github.com/m3ng9i/ran/tree/master/server), which doesn't support ranges without spaces. It seems the server didn't handle this case properly. According to RFC 7233, it should support both cases: with and without spaces.

@mmaietta
Copy link
Collaborator

Do we need to update ran then for supporting both formats per RFC 7233? Will that suffice or do we need a new command-line server for executing this workflow (and a few others that use ran)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot download differentially

3 participants