Skip to content

Use commonDistDirectory for main.js in dev mode #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use commonDistDirectory for main.js in dev mode #399

wants to merge 1 commit into from

Conversation

maximilize
Copy link

The dist directory was hardcoded, replaced this with the commonDistDirectory option.
Closes #68

@maximilize
Use commonDistDirectory for main.js in dev mode
59f8153 
The `dist` directory was hardcoded, replaced this with the `commonDistDirectory` option.
Closes electron-userland#68
@maximilize
Copy link
Author

I just saw that this issue was already addressed in #351 and #367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@an6r an6r an6r approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev mode does not follow webpack output
2 participants
@maximilize @an6r